Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update home.html #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update home.html #26

wants to merge 1 commit into from

Conversation

kartik1000
Copy link

Button Added to clear options below the time table
what-slot screenshot

arnav-t
arnav-t requested changes Dec 14, 2018
View reviewed changes
Copy link
Owner

@arnav-t arnav-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button does nothing. It is supposed to clear the timetable by removing the *-danger bootstrap classes from the timetable.

@Manvi07
Copy link

Manvi07 commented Dec 14, 2018

@arnav-t , Could you please elucidate on how you'd like to have it?

@arnav-t
Copy link
Owner

arnav-t commented Dec 14, 2018

@Manvi07 Well for one the button should do something when it's clicked.
It should:

  • Be on the same row as the "Click on a slot..." text.
  • Be stylized using bootstrap classes with an icon (e.g from Font Awesome).
  • Most importantly, it should clear the timetable. The version included in the PR does nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnav-t arnav-t arnav-t requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartik1000 @Manvi07 @arnav-t